Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert display functions into Pretty instances #10526

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Convert display functions into Pretty instances #10526

merged 1 commit into from
Dec 18, 2024
+46 −46

Conversation

9999years
Copy link
Collaborator

We have a lot of showType functions that are effectively a Pretty instance but less composable. Let's make them proper Pretty instances.

Split off of #10524

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@9999years 9999years marked this pull request as ready for review November 5, 2024 17:41
@9999years 9999years closed this Dec 9, 2024
@9999years 9999years deleted the pretty-pretty branch December 9, 2024 17:33
@grayjay
Copy link
Collaborator

grayjay commented Dec 10, 2024

@9999years Why did you close this PR? I liked that it reduced the size of #10524, and I thought that it was a great cleanup on its own.

@9999years
Copy link
Collaborator Author

@grayjay Oh okay, I thought it wasn't significant enough to be worth the effort, but i can fix it up.

@9999years 9999years restored the pretty-pretty branch December 10, 2024 17:26
@9999years 9999years reopened this Dec 10, 2024
@9999years 9999years force-pushed the pretty-pretty branch 2 times, most recently from fa7fa8b to 9f199e7 Compare December 10, 2024 17:46
grayjay
grayjay approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@grayjay grayjay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@9999years 9999years added the merge me Tell Mergify Bot to merge label Dec 10, 2024
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Dec 11, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@geekosaur
Copy link
Collaborator

Needs manual rebase and merge+no rebase (branch is MercuryTechnologies:pretty-pretty)

@geekosaur
Copy link
Collaborator

Hm. RTD build failed oddly. Can you update this again, since RTD builds aren't under GHA control and RTD itself provides no restart mechanism?

@9999years
Convert display functions into Pretty instances
d2bb924 
We have a lot of `showType` functions that are effectively a `Pretty`
instance but less composable. Let's make them proper `Pretty` instances.

Split off of haskell#10524
@9999years
Copy link
Collaborator Author

RTD itself provides no restart mechanism?

😱

@geekosaur
Copy link
Collaborator

Yeh, we've run into this a few times before, RTD burps and you have to push some meaningless update to make it run again.

@mergify mergify bot merged commit 1f36bf8 into haskell:master Dec 18, 2024
48 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2024

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #10526 has been dequeued. Pull request automatically merged by a merge action.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@geekosaur
Copy link
Collaborator

…wha?

@ulysses4ever
Copy link
Collaborator

I must admit: it is pretty funny 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grayjay grayjay grayjay approved these changes

@geekosaur geekosaur geekosaur approved these changes

Assignees
No one assigned
Labels
cabal-install: solver merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge merge+no rebase ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@9999years @grayjay @geekosaur @ulysses4ever