Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish the architectures powerpc64 and powerpc64le? #9534

Closed
mpilgrem opened this issue Dec 17, 2023 · 0 comments
Closed

Distinguish the architectures powerpc64 and powerpc64le? #9534

mpilgrem opened this issue Dec 17, 2023 · 0 comments

Comments

@mpilgrem
Copy link
Collaborator

The common values of System.Info.arch (from base) include powerpc64 and powerpc64le. Cabal-syntax's Distribution.System.archAliases (not exported, but underpinning buildArch) maps both of those values to the single data constructor Distribution.System.PPC64 :: Distribution.System.Arch.

A user of Stack considers that the two architectures should be distinguished (see commercialhaskell/stack#6379). (Stack makes use of Cabal-syntax's Distribution.System.buildPlatform.)

I assume if they were distinguished, Cabal would map powerpc64 to the existing PPC64 and powerpc64le to a new constructor, say PPC64LE.

There would be an interaction with GHC's Hadrian:
https://gitlab.haskell.org/ghc/ghc/-/blame/master/hadrian/src/Hadrian/Haskell/Cabal.hs#L62

@bgamari, FYI.

mpilgrem added a commit that referenced this issue Dec 17, 2023
mpilgrem added a commit that referenced this issue Dec 18, 2023
mpilgrem added a commit that referenced this issue Feb 19, 2024
@mergify mergify bot closed this as completed in fa3f6b6 Feb 22, 2024
mergify bot added a commit that referenced this issue Feb 22, 2024
Fix #9534 Add constructor `PPC64LE` to type `Arch`, for powerpc64le
erikd pushed a commit to erikd/cabal that referenced this issue Apr 22, 2024
…c64le

Also makes consequent changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant