Skip to content

Commit

Permalink
Fix #9534 Add constructor PPC64LE to type Arch, for powerpc64le
Browse files Browse the repository at this point in the history
Also makes consequent changes.
  • Loading branch information
mpilgrem committed Dec 18, 2023
1 parent feaa338 commit cf8b0b8
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 3 deletions.
10 changes: 7 additions & 3 deletions Cabal-syntax/src/Distribution/System.hs
Original file line number Diff line number Diff line change
Expand Up @@ -181,13 +181,14 @@ buildOS = classifyOS Permissive System.Info.os

-- ------------------------------------------------------------

-- | These are the known Arches: I386, X86_64, PPC, PPC64, Sparc,
-- | These are the known Arches: I386, X86_64, PPC, PPC64, PPC64LE, Sparc,
-- Sparc64, Arm, AArch64, Mips, SH, IA64, S390, S390X, Alpha, Hppa,
-- Rs6000, M68k, Vax, RISCV64, LoongArch64, JavaScript and Wasm32.
--
-- The following aliases can also be used:
-- * PPC alias: powerpc
-- * PPC64 alias : powerpc64, powerpc64le
-- * PPC64 alias : powerpc64
-- * PPC64LE alias : powerpc64le
-- * Mips aliases: mipsel, mipseb
-- * Arm aliases: armeb, armel
-- * AArch64 aliases: arm64
Expand All @@ -196,6 +197,7 @@ data Arch
| X86_64
| PPC
| PPC64
| PPC64LE
| Sparc
| Sparc64
| Arm
Expand Down Expand Up @@ -227,6 +229,7 @@ knownArches =
, X86_64
, PPC
, PPC64
, PPC64LE
, Sparc
, Sparc64
, Arm
Expand All @@ -251,7 +254,8 @@ archAliases :: ClassificationStrictness -> Arch -> [String]
archAliases Strict _ = []
archAliases Compat _ = []
archAliases _ PPC = ["powerpc"]
archAliases _ PPC64 = ["powerpc64", "powerpc64le"]
archAliases _ PPC64 = ["powerpc64"]
archAliases _ PPC64LE = ["powerpc64le"]
archAliases _ Mips = ["mipsel", "mipseb"]
archAliases _ Arm = ["armeb", "armel"]
archAliases _ AArch64 = ["arm64"]
Expand Down
1 change: 1 addition & 0 deletions Cabal/src/Distribution/Simple/GHC/Internal.hs
Original file line number Diff line number Diff line change
Expand Up @@ -779,6 +779,7 @@ profDetailLevelFlag forLib mpl =
ghcArchString :: Arch -> String
ghcArchString PPC = "powerpc"
ghcArchString PPC64 = "powerpc64"
ghcArchString PPC64LE = "powerpc64le"
ghcArchString other = prettyShow other

-- | GHC's rendering of its host or target 'OS' as used in its platform
Expand Down
1 change: 1 addition & 0 deletions Cabal/src/Distribution/Simple/PreProcess.hs
Original file line number Diff line number Diff line change
Expand Up @@ -849,6 +849,7 @@ platformDefines lbi =
X86_64 -> ["x86_64"]
PPC -> ["powerpc"]
PPC64 -> ["powerpc64"]
PPC64LE -> ["powerpc64le"]
Sparc -> ["sparc"]
Sparc64 -> ["sparc64"]
Arm -> ["arm"]
Expand Down
11 changes: 11 additions & 0 deletions changelog.d/issue-9534
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
synopsis: Distinguish `powerpc64le`, by adding `PPC64LE` constructor to type `Arch`
packages: Cabal Cabal-syntax
issues: #9534

description: {

Adds constructor `PPC64LE` to type `Arch` to distinguish architecture
powerpc64le from powerpc64. Existing constructor `PPC64` now exclusively
represents powerpc64.

}

0 comments on commit cf8b0b8

Please sign in to comment.