Move all endianness/byte-order CPP into one module #659
Conversation
| , whenBigEndian | ||
| ) where | ||
|
|
||
| data ByteOrder |
There was a problem hiding this comment.
Shall we reuse GHC.ByteOrder.ByteOrder?
There was a problem hiding this comment.
It makes sense to do so. It can wait until I make a pass at removing the various old-ghc cruft, though.
There was a problem hiding this comment.
I mean, we can already reuse the type itself?..
There was a problem hiding this comment.
It's added in base-4.11 while we currently have base >= 4.9. I guess there is a compatibility package ghc-byteorder but that seems like re-arranging deck chairs on the Titanic since we will discontinue support for such old ghc versions at our convenience.
This isn't a battle worth fighting, though.
|
|
||
| module Data.ByteString.Utils.ByteOrder | ||
| ( ByteOrder(..) | ||
| , hostByteOrder |
There was a problem hiding this comment.
Is the name intentionally different from targetByteOrder for cross-compilation purposes?
There was a problem hiding this comment.
Since bytestring is not a compiler the notion of "target" doesn't really make sense. The name in base is confusing.
(cherry picked from commit 161780a)
I can't be bothered to remember the right combination of
#include ...and#ifdefto check this. So I'd like to remove the need entirely.