Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add WASM job #656

Merged
merged 5 commits into from
Sep 19, 2024
Merged

CI: add WASM job #656

merged 5 commits into from
Sep 19, 2024

Conversation

Bodigrim
Copy link
Contributor

@Bodigrim Bodigrim commented Feb 5, 2024

Draft, just to get feedback from GHA.

@Bodigrim Bodigrim force-pushed the more-ci branch 3 times, most recently from 45430fe to dd91633 Compare February 5, 2024 22:16
@Bodigrim Bodigrim changed the title More CI job More CI jobs Feb 5, 2024
@Bodigrim Bodigrim force-pushed the more-ci branch 2 times, most recently from 3aa36d9 to 2068636 Compare February 5, 2024 22:31
@Bodigrim
Copy link
Contributor Author

Bodigrim commented Feb 5, 2024

@amesgen @TerrorJack any clues what's up with WASM CI job here?

    IO
      readFile.writeFile:                                  OK (0.04s)
        +++ OK, passed 100 tests.
      readFile.writeFile:                                  OK (0.04s)
        +++ OK, passed 100 tests.
      readFile.writeFile:                                  OK (0.04s)
        +++ OK, passed 100 tests.
      readFile.writeFile:                                  OK (0.04s)
        +++ OK, passed 100 tests.
      appendFile        :                                  FAIL
        *** Failed! Falsified (after 5 tests and 4 shrinks):
        "\NUL"
        "\NUL"
        "\NUL" /= "\NUL\NUL"
        Use --quickcheck-replay=901105 to reproduce.
        Use -p '$0=="All.Properties.IO.appendFile        "' to rerun this test only.
      appendFile        :                                  FAIL
        *** Failed! Falsified (after 5 tests and 3 shrinks):
        "\NUL"
        "\NUL"
        "\NUL" /= "\NUL\NUL"
        Use --quickcheck-replay=109253 to reproduce.
        Use -p '$0=="All.Properties.IO.appendFile        "' to rerun this test only.
      appendFile        :                                  FAIL
        *** Failed! Falsified (after 4 tests):
        "\SOH\SOH"
        "\STX"
        "\STX\SOH" /= "\SOH\SOH\STX"
        Use --quickcheck-replay=958508 to reproduce.
        Use -p '$0=="All.Properties.IO.appendFile        "' to rerun this test only.
      appendFile        :                                  FAIL
        *** Failed! Falsified (after 5 tests):
        "\NUL"
        "\STX"
        "\STX" /= "\NUL\STX"
        Use --quickcheck-replay=699923 to reproduce.
        Use -p '$0=="All.Properties.IO.appendFile        "' to rerun this test only.

writeFile . readFile passes, but if there is appendFile in between, it fails.

@TerrorJack
Copy link

openFile with AppendMode in wasm backend is only recently fixed by https://gitlab.haskell.org/ghc/ghc/-/merge_requests/11697 (see openFile009 test case), though ghc-wasm-meta's master branch has been stalled for a while because of a wasi-sdk bump that hasn't landed in 9.6/9.8 branches yet...

Maybe try using ghcup to set it up, my impression is it pulls in more recent metadata.

@clyring
Copy link
Member

clyring commented Feb 7, 2024

I've seen something just like this Windows/9.8 failure before, in CI for the bytestring-0.11 branch at 834bbe4. It was "fixed" when I bumped the version in bytestring.cabal to one that differed from the relevant ghc boot library version.

@Bodigrim Bodigrim force-pushed the more-ci branch 2 times, most recently from 716cb07 to 409b4fc Compare September 7, 2024 13:13
@Bodigrim Bodigrim changed the title More CI jobs CI: add WASM job Sep 7, 2024
@Bodigrim Bodigrim marked this pull request as ready for review September 7, 2024 13:39
Copy link
Member

@clyring clyring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I'm fully competent to review this, but it looks very plausible and seems to be working as expected.

@Bodigrim Bodigrim merged commit 3f9773d into haskell:master Sep 19, 2024
26 of 27 checks passed
@Bodigrim Bodigrim deleted the more-ci branch September 19, 2024 18:32
Bodigrim added a commit that referenced this pull request Oct 9, 2024
* Don't build tests with threaded runtime on WASM

* Skip lifting tests on WASM

* Tests: improve reporting of mismatches for IO tests

* Add WASM CI job

* CI: upgrade incantations for emualted tests
Bodigrim added a commit that referenced this pull request Oct 15, 2024
* Don't build tests with threaded runtime on WASM

* Skip lifting tests on WASM

* Tests: improve reporting of mismatches for IO tests

* Add WASM CI job

* CI: upgrade incantations for emualted tests
@Bodigrim Bodigrim added this to the 0.12.2.0 milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants