Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data.ByteString.Lazy.dropEnd: Use two-pointers technique #629

Merged
merged 8 commits into from
Feb 4, 2024

Commits on Nov 29, 2023

  1. Data.ByteString.Lazy.dropEnd: Use two-pointers technique

    This can be seen as using the input itself as an implicit
    queue; we formerly copied its chunks into an explicit queue.
    
    By writing the key logic as a polymorphic `splitAtEndFold`,
    it was easy to re-use it for `takeEnd`; the latter function
    should now operate in constant stack space and can release
    initial chunks of a very long input string sooner.
    clyring committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    6d6f16e View commit details
    Browse the repository at this point in the history
  2. Fix a very silly bug, and strengthen tests

    ...so that a plain 'cabal test' finds the bug almost every try
    instead of finding it only every few dozen tries
    clyring committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    a48379b View commit details
    Browse the repository at this point in the history
  3. Actually work around the poison instance

    (Some re-compilation check somewhere set a trap for me.)
    
    This also replaces fromIntegral with intToIndexTy in a few places.
    clyring committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    0fab8f3 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Configuration menu
    Copy the full SHA
    6b943c2 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Configuration menu
    Copy the full SHA
    39af6cf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0ced807 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. Configuration menu
    Copy the full SHA
    df039bd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    071a062 View commit details
    Browse the repository at this point in the history