Tweak UTF-8 validation 'roll back' logic #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes haskell#620. We must roll back some if the last SIMD block contains an incomplete multi-byte code point. The old logic for this would roll back by one even if there were zero SIMD blocks processed, which is exactly the bug.
clyring
added a commit
that referenced
this pull request
Oct 27, 2023
Fixes #620. We must roll back some if the last SIMD block contains an incomplete multi-byte code point. The old logic for this would roll back by one even if there were zero SIMD blocks processed, which is exactly the bug.
Bodigrim
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #620. We must roll back some if the last SIMD block contains an incomplete multi-byte code point. The old logic for this would roll back by one even if there were zero SIMD blocks processed, which is exactly the bug.