Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sourcehut generator #563

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Add sourcehut generator #563

wants to merge 23 commits into from

Conversation

fgaz
Copy link

@fgaz fgaz commented Nov 29, 2021

Closes #526

TODO:

  • tests
  • figure out how to avoid parseOptionsSrht (see TODO)

@phadej
Copy link
Collaborator

phadej commented Nov 29, 2021

Don't edit readme.

src/HaskellCI/Cli.hs Outdated Show resolved Hide resolved
@fgaz
Copy link
Author

fgaz commented Nov 29, 2021

Hmm, why isn't CI running?

edit: for some reason this comment made "1 workflow awaiting approval" appear. it wasn't shown before. github being github i guess.

@fgaz fgaz marked this pull request as ready for review November 29, 2021 20:00
test/Tests.hs Outdated Show resolved Hide resolved
@fgaz
Copy link
Author

fgaz commented Dec 1, 2021

What should I do with the tell_env hint? The github backend also calls it like that, but it's inside a where there, which is fine for hlint

@phadej
Copy link
Collaborator

phadej commented Dec 1, 2021

What should I do with the tell_env hint? The github backend also calls it like that, but it's inside a where there, which is fine for hlint

I don't know what happens.hlint is probably drunk. Add ignore to .hlint.yaml, I don't like "Use camelCase" hint anyway.

@phadej
Copy link
Collaborator

phadej commented Jun 2, 2022

@fgaz what is the status of this PR?

@fgaz
Copy link
Author

fgaz commented Jun 3, 2022

I've been using this branch for my personal projects. I don't remember too well what was the status of this but it looks like all comments are resolved. Let's rebase and see if tests still pass

@fgaz
Copy link
Author

fgaz commented Jun 3, 2022

Hmm, I guess I'll need to update it to use ghcup since the ppa is no longer maintained

edit: by the way i see that travis is also still using the ppa even for ghc versions that aren't there
edit2: oh ok:

There is also legacy Travis-CI configuration generator, which is unmaintained.

@fgaz
Copy link
Author

fgaz commented Jun 3, 2022

Here you go, this should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sourcehut / sr.ht backend
2 participants