Allow diffing of config files and regendata #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merijn
force-pushed
the
diff
branch
3 times, most recently
from
021ab22
to
39d9630
Compare
|
@phadej How do you feel about this? Obviously needs a bit more polish in the form tests and bike-shedding how commandline flags affect the diff command (if they even should?). The current Dump functionality can be trivially replaced by (and augmented to output dumps arbitrary configs, instead of just the default). I'm just to lazy to finish up the last polish if you're not interested anyway :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I talked about ages ago on IRC, I finally got around to finishing it up.
Adds a new
diff-configcommand that takes a config file and/or generated CI workflow and prints a diff of the configurations. There's no tests atm and there is some bikeshedding to be done with regards to: Should we take commandline flags/existing config files into account? If yes, should those be applied to the "old" or the "new" config?In principle this also obsoletes/can replace the old dump-config command.