Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-31751, VAULT-31752: removed_from_cluster in vault status #28938

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

miagilepner
Copy link
Contributor

Description

This PR adds an optional field to the sys/seal-status endpoint and vault status output. If the storage/HA backend supports removability (currently this is only raft), then removed_from_cluster is included in the output with a value of true or false.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • [] ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@miagilepner miagilepner added this to the 1.19.0-rc milestone Nov 18, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 18, 2024
Copy link

github-actions bot commented Nov 18, 2024

CI Results:
All Go tests succeeded! ✅

@miagilepner miagilepner marked this pull request as ready for review November 18, 2024 13:24
@miagilepner miagilepner requested a review from a team as a code owner November 18, 2024 13:24
Copy link

Build Results:
All builds succeeded! ✅

@miagilepner miagilepner merged commit 4b98fd9 into main Nov 19, 2024
128 of 134 checks passed
@miagilepner miagilepner deleted the miagilepner/VAULT-31751-removed-status branch November 19, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants