Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP Secrets Engine api documentation: URL to external link is broken, this PR corrects the URL #28578

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gerardma77
Copy link
Contributor

Description

What does this PR do?

old:
Screenshot 2024-10-03 at 11 58 59

new:

Screenshot 2024-10-03 at 11 59 26

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@gerardma77 gerardma77 requested a review from kwagga October 3, 2024 10:00
@gerardma77 gerardma77 requested a review from a team as a code owner October 3, 2024 10:00
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Oct 3, 2024

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@kwagga kwagga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants