UI: Fix oidc auth method missing default_role field #28539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
hellobontempo
commented
Sep 30, 2024
| @@ -32,7 +32,7 @@ | |||
| aria-label={{or @name "masked input"}} | |||
| {{on "change" this.onChange}} | |||
| {{on "keyup" (fn this.handleKeyUp @name)}} | |||
| data-test-textarea={{or @name ""}} | |||
| data-test-input={{or @name ""}} | |||
There was a problem hiding this comment.
There was a lot of logic in tests because this selector differed from the standard pattern, updated it and relevant selectors to make future tests easier to write
There was a problem hiding this comment.
I've also run into this. Thank you!
hellobontempo
commented
Sep 30, 2024
| // These models use openAPI so we assert the form inputs using an acceptance test | ||
| // The default selector is to use GENERAL.inputByAttr() | ||
| // custom fields should be added to the this.customSelectorss object | ||
| module('Acceptance | auth enable tune form test', function (hooks) { |
There was a problem hiding this comment.
I only added tests for azure, jwt, oidc, okta and ldap for now. We can expand as needed
|
✅ enterprise tests |
Monkeychip
approved these changes
Oct 1, 2024
Yep - mentioned that in my previous comment here: Would you prefer I mention it in the description next time? |
6 tasks
hellobontempo
commented
Oct 1, 2024
| @@ -136,26 +136,27 @@ export function filterPathsByItemType(pathInfo: PathsInfo, itemType: string): Pa | |||
| * This object maps model names to the openAPI path that hydrates the model, given the backend path. | |||
| */ | |||
| const OPENAPI_POWERED_MODELS = { | |||
| 'role-ssh': (backend: string) => `/v1/${backend}/roles/example?help=1`, | |||
hellobontempo
commented
Oct 1, 2024
| 'auth-config/azure': (backend: string) => `/v1/auth/${backend}/config?help=1`, | ||
| 'auth-config/cert': (backend: string) => `/v1/auth/${backend}/config?help=1`, | ||
| 'auth-config/gcp': (backend: string) => `/v1/auth/${backend}/config?help=1`, | ||
| 'auth-config/github': (backend: string) => `/v1/auth/${backend}/config?help=1`, | ||
| 'auth-config/jwt': (backend: string) => `/v1/auth/${backend}/config?help=1`, | ||
| 'auth-config/kubernetes': (backend: string) => `/v1/auth/${backend}/config?help=1`, | ||
| 'auth-config/ldap': (backend: string) => `/v1/auth/${backend}/config?help=1`, | ||
| 'auth-config/oidc': (backend: string) => `/v1/auth/${backend}/config?help=1`, |
There was a problem hiding this comment.
this is the only new one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
default_rolemissing from OIDC form. The field was accidentally removed when #27764 was implemented becauseauth-config/oidcwas left out of the helper const. This happened because the model inherits fromjwtmaking it easy to miss during the refactor. I added some test coverage for some of these open api models so it doesn't happen againbefore
after
TODO only if you're a HashiCorp employee
to N, N-1, and N-2, using the
backport/ent/x.x.x+entlabels. If this PR is in the CE repo, you should only backport to N, using thebackport/x.x.xlabel, not the enterprise labels.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.