Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log message indicating expected goroutine dump behavior #28535

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

ltcarbonell
Copy link
Contributor

Description

This PR adds an informational log message to clarify that the observed goroutine dumps are expected behavior and do not indicate a panic. The log message reassures that Vault is still running normally and can be unsealed. This should help reduce confusion when encountering goroutine dumps in the logs.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 30, 2024
Copy link
Collaborator

@anwittin anwittin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding a clear message to the output

Copy link

CI Results:
All Go tests succeeded! ✅

@ltcarbonell ltcarbonell enabled auto-merge (squash) September 30, 2024 15:47
Copy link

Build Results:
All builds succeeded! ✅

@ltcarbonell ltcarbonell merged commit 2d46c8d into main Sep 30, 2024
94 checks passed
@ltcarbonell ltcarbonell deleted the vault-29295-log-message branch September 30, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants