Update PKI tests to leverage the tidy-status test helper #28531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendpclark
added
test
pr/no-changelog
pr/no-milestone
backport/ent/1.15.x+ent
backport/ent/1.16.x+ent
github-actions
bot
added
the
hashicorp-contributed-pr
stevendpclark
commented
Sep 27, 2024
| require.NoError(t, err, "failed registering account") | ||
| t.Logf("got account URI: %v", acct.URI) |
There was a problem hiding this comment.
Swapped to avoid a nil panic if erris set and not acct.
|
CI Results: |
|
Build Results: |
- I have a suspicion the for loop with the timer can be infinite loops in certain circumstances. Instead leverage the normal test helpers for fetching tidy status
stevendpclark
force-pushed
the
stevendpclark/vault-31290-use-common-helpers-for-tidy
branch
from
85f257f
to
e2f41f4
Compare
stevendpclark
deleted the
stevendpclark/vault-31290-use-common-helpers-for-tidy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've checked and no ENT specific tests call this function, so the API change is safe.
TODO only if you're a HashiCorp employee
to N, N-1, and N-2, using the
backport/ent/x.x.x+entlabels. If this PR is in the CE repo, you should only backport to N, using thebackport/x.x.xlabel, not the enterprise labels.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.