Log when MAP_POPULATE gets disabled #28526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
digivava
commented
Sep 26, 2024
| @@ -447,6 +451,7 @@ func NewRaftBackend(conf map[string]string, logger log.Logger) (physical.Backend | |||
| } | |||
| } | |||
|
|
|||
| // Create the log store. | |||
There was a problem hiding this comment.
I added this to match the comment up above where we explain that we're creating the FSM. Helps people like me who are new to the concept that Vault has two different databases that need to be created.
raskchanky
reviewed
Sep 30, 2024
…corp/vault into VAULT-23020/log_when_mmap_disabled
digivava
added
backport/ent/1.16.x+ent
This was referenced Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a log line during the log store and FSM setup process that warns when Linux's MAP_POPULATE flag for mmap has been disabled. (That flag populates page tables ahead of time before we try to open a database file, which helps limit page faults and thus speeds up the process.)
Without this log message, the Vault process appears to hang for a long period of time while it tries to open up a large database. This log line will help warn users so they don't just think Vault is being broken and unresponsive.
Note that the
unix.MAP_POPULATEflag is only available on Linux, so Go won't compile if I reference it in files that don't end in_linux.go, hence the slight gymnastics.I've also added some comments to help noobs to these concepts like myself understand how this flag is used.
TODO only if you're a HashiCorp employee
to N, N-1, and N-2, using the
backport/ent/x.x.x+entlabels. If this PR is in the CE repo, you should only backport to N, using thebackport/x.x.xlabel, not the enterprise labels.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.