Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue with Lost Timezone in Metadata for Database Secret Engines #28509

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

ltcarbonell
Copy link
Contributor

@ltcarbonell ltcarbonell commented Sep 25, 2024

Description

This PR fixes an issue where the Location object in the metadata is lost when converting entries to JSON for storage in all database secret engines. As a result, the "local" timezone was missing upon retrieval, causing it to default to UTC. This fix ensures that the Location object retains its value, so the correct timezone is preserved when reading from storage.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@ltcarbonell ltcarbonell requested a review from a team as a code owner September 25, 2024 21:23
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 25, 2024
Copy link

github-actions bot commented Sep 25, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Sep 25, 2024

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fairclothjm
Copy link
Contributor

@ltcarbonell I think we will want to backport this

@ltcarbonell ltcarbonell added backport/ent/1.15.x+ent Changes are backported to 1.15.x+ent backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.17.x backport/1.18.x labels Sep 25, 2024
@ltcarbonell ltcarbonell merged commit b861d8b into main Sep 25, 2024
103 checks passed
@ltcarbonell ltcarbonell deleted the vault-31163-db-rotation-schedule-tz branch September 25, 2024 22:40
@ltcarbonell ltcarbonell added backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent and removed backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.15.x+ent Changes are backported to 1.15.x+ent labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.17.x backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants