Set broken notify systemd unit type back to simple.
#28029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should never have been changed. The systemd unit in production is currently invalid using the vault binary in `ExecStart` instead of a proper dus notify script. Reversing hashicorp#14385
|
Thank you for this; I'll get an engineer to review it. Thanks! |
divyaac
added
release/packaging
dependencies
|
I'm going to close this based on the discussion in this thread: #27935 (comment) To summarize: this is caused by an upstream dependency, not Vault. There's more detail in this support article: https://support.hashicorp.com/hc/en-us/articles/20562543907859-Vault-1-13-7-and-Linux-DBus-leftover-processes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should never have been changed. The systemd unit in production is currently invalid using the vault binary in
ExecStartinstead of a proper dbus notify script.Reversing #14385
Description
This PR fixes pull 14385 which never should have been merged and introduced a broken systemd unit into production customer environments of Vault and Vault Enterprise. The fact an outsider whithout understanding of systemd got an invalid merge into production packaging is alarming.
Issue: #27935