core/api: Add missing LICENSE files to sub-modules #27920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go module tooling mandates that each sub-module contains its own LICENSE file. If absent, it defaults to the LICENSE file in the root of the git repository. This resulted in the api/auth/* modules erroneously inheriting the BUSL license instead of the correct MPL license, as indicated by the SPDX info in the actual API code. This update ensures that module documentation is displayed correctly on pkg.go.dev and resolves issues with various tools showing incorrect license information for the sub-modules. Signed-off-by: Tero Saarni <[email protected]>
tsaarni
force-pushed
the
missing-api-license
branch
from
1f07321
to
e8ebc45
Compare
|
Just a friendly nudge to see if you've had a chance to take a look this PR yet? |
|
Sorry to bother again, but wanted to check if this could be merged? 🙏 |
|
Hey there! Thanks for this. I'm going to look into this and try and get this over the finish line as this makes sense to me and seems to be well-considered but I want to triple check everything first considering it's legal/copyright-related. |
VioletHynes
approved these changes
Sep 23, 2024
|
@VioletHynes Great news! Thank you for your effort as well, greatly appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change copies
./api/LICENSEto each sub-module./api/auth/*Fixes #27775
Description
Go module tooling mandates that each sub-module contains its own LICENSE file. If absent, it defaults to the LICENSE file in the root of the git repository. This resulted in the
api/auth/*modules erroneously inheriting the BUSL license instead of the correct MPL license, as indicated by the SPDX info in the actual API code.See https://go.dev/ref/mod#vcs-license
Adding the LICENSE files to each module ensures that module documentation is displayed correctly on pkg.go.dev and resolves issues with various tools, such as go-licenses, showing incorrect license information for the sub-modules.