UI: convert mount backend code to TS #27349
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
|
|
||
| interface Args { | ||
| mountModel: MountModel; | ||
| mountType: 'secret' | 'auth'; |
There was a problem hiding this comment.
got these options from here:
| export default class MountBackendForm extends Component { | ||
| @service store; | ||
| @service flashMessages; | ||
| type MountModel = MountSecretBackendModel | AuthEnableModel; |
There was a problem hiding this comment.
looks like this component is only rendered on 2 routes:
in both instances, the component directly receives the result of the model hook as its argument for @mountModel. this is why i set up the types this way.
initially, i thought about setting the type to be either SecretEngineModel or AuthMethodModel. however, this setup provides more flexibility -- it allows for potential changes in the route model that may include properties not specifically part of the underlying Ember data models.
| @@ -58,8 +72,8 @@ export default class MountBackendForm extends Component { | |||
| } | |||
| } | |||
|
|
|||
| typeChangeSideEffect(type) { | |||
| if (!this.args.mountType === 'secret') return; | |||
There was a problem hiding this comment.
TS caught this, which seemed like a typo so i fixed it 😮
| @@ -6,8 +6,13 @@ | |||
| import Route from '@ember/routing/route'; | |||
| import { service } from '@ember/service'; | |||
|
|
|||
| import type { ModelFrom } from 'vault/vault/route'; | |||
| import type Store from '@ember-data/store'; | |||
There was a problem hiding this comment.
i noticed we've been importing the Store type 2 different ways. one is this way, and the other is like this:
however importing the type from @ember-data works better since it recognizes that properties like isDestroying etc are indeed on that type. the alternative way of importing Store caused a bunch of type errors.
There was a problem hiding this comment.
That's strange, because in the store.d.ts file we're extending Store from @ember-data/store 🤔 Should be harmless here since we're not using any of the extended methods here, but smells like something wrong in our ts setup
|
Build Results: |
|
CI Results: |
🛠️ Description
Migrating a few files to TS, as having types will help us build the WIF UI.