Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Remove "encryption" from transit actions #27346

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

hashishaw
Copy link
Contributor

@hashishaw hashishaw commented Jun 4, 2024

Not all transit keys can encrypt, so this PR updates the language on the actions within the Transit secret engine to remove "encryption". Language is important!

  • Ent tests pass

Screenshots include previous on left/after on right

Screenshot 2024-06-03 at 15 26 15 Screenshot 2024-06-03 at 15 27 26

@hashishaw hashishaw added ui backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.17.x labels Jun 4, 2024
@hashishaw hashishaw added this to the 1.16.4 milestone Jun 4, 2024
@hashishaw hashishaw requested a review from a team as a code owner June 4, 2024 15:25
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 4, 2024
@hashishaw hashishaw added the backport/ent/1.15.x+ent Changes are backported to 1.15.x+ent label Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Jun 4, 2024

CI Results:
All Go tests succeeded! ✅

Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Thank you for being throughout!

@hashishaw hashishaw merged commit 131d1e2 into main Jun 4, 2024
31 checks passed
@hashishaw hashishaw deleted the ui/VAULT-27072/transit-button-language branch June 4, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.15.x+ent Changes are backported to 1.15.x+ent backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.17.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants