Skip to content

Commit

Permalink
Update vault/identity_store_util.go
Browse files Browse the repository at this point in the history
Co-authored-by: Paul Banks <[email protected]>
  • Loading branch information
elliesterner and banks authored Jul 23, 2024
1 parent b0ebd32 commit a6c810a
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions vault/identity_store_util.go
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,12 @@ func (i *IdentityStore) loadGroups(ctx context.Context) error {

if errors.Is(err, logical.ErrReadOnly) {
// This is an imperfect solution to unblock customers who are running into
// a readonly error during a DR failover (jira #28191). More specifically, there
// are duplicate aliases in storage that are merged during loadEntities. Vault
// attempts to remove these deleted entities from the group, but fails in the case
// where the node is a PR secondary because the RPC client is not yet initialized
// and the storage is read-only.
// a readonly error during a DR failover (jira #28191). More specifically, if there
// are duplicate aliases in storage then they are merged during loadEntities. Vault
// attempts to remove the deleted duplicate entities from their groups to clean up.
// If the node is a PR secondary though it will fail because the RPC client
// is not yet initialized and the storage is read-only. This prevents the cluster from
// unsealing entirely and can potentially block a DR failover from succeeding.
i.logger.Warn("received a read only error while trying to upsert group to storage")
} else if err != nil {
txn.Abort()
Expand Down

0 comments on commit a6c810a

Please sign in to comment.