Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for ntpd service on r/host #2232

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add support for ntpd service on r/host #2232

wants to merge 3 commits into from
+305 −2

Conversation

burnsjared0415
Copy link

@burnsjared0415 burnsjared0415 commented Jul 2, 2024 •
edited by tenthirtyam
Loading

Description

Added support for ntpd for services on r/vsphere_host. This allows for ntpd service settings and policy to be added to a host resource.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Release Note

  • resource/host - Added support for ntpd for services on r/vsphere_host. This allows for ntpd service settings and policy to be added to a host resource and future expansion of additional services.

References

Closes #1131

@burnsjared0415 burnsjared0415 requested a review from a team as a code owner July 2, 2024 16:45
@hashicorp-cla-app HashiCorp CLA App
Copy link

hashicorp-cla-app bot commented Jul 2, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added documentation Type: Documentation provider Type: Provider needs-review Status: Pull Request Needs Review labels Jul 2, 2024
@tenthirtyam tenthirtyam force-pushed the feature/added-ntpd-support-for-resource_vsphere_host branch from fa9ce05 to e1b8352 Compare July 2, 2024 17:02
@tenthirtyam tenthirtyam added this to the v2.8.3 milestone Jul 2, 2024
@tenthirtyam tenthirtyam changed the title feature: add support for ntpd service on resource_vsphere_host feat: add support for ntpd service on r/host Jul 2, 2024
@tenthirtyam
Copy link
Collaborator

@spacegospod - this is from Jared Burns on my team.

@tenthirtyam tenthirtyam added enhancement Type: Enhancement area/host Area: Host labels Jul 2, 2024
@burnsjared0415 @tenthirtyam
feat: add support for ntpd service on r/host
edce986 
Added support for ntpd for services on `r/vsphere_host`. This allows for ntpd service settings and policy to be added to a host resource.

Signed-off-by: Jared Burns <[email protected]>
@tenthirtyam tenthirtyam force-pushed the feature/added-ntpd-support-for-resource_vsphere_host branch from e1b8352 to edce986 Compare July 2, 2024 17:09
@burnsjared0415
feature: add support for ntpd service on resource_vsphere_host
5ad7980 
Added support for ntpd for services on resource_vsphere_host, this will allow for ntpd service to be added during import of host.

Signed-off-by: Jared Burns <[email protected]>
@tenthirtyam tenthirtyam force-pushed the feature/added-ntpd-support-for-resource_vsphere_host branch from 401b3a3 to 9e7e8f6 Compare July 2, 2024 17:20
tenthirtyam
tenthirtyam requested changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated to docs and the example for you and fixed the unit test failure - please pull the latest.

Added some suggested changes.

@burnsjared0415 burnsjared0415 force-pushed the feature/added-ntpd-support-for-resource_vsphere_host branch from 9e7e8f6 to 668bcee Compare July 2, 2024 18:01
spacegospod
spacegospod reviewed Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@spacegospod spacegospod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jared, welcome on board!

Do you think you can sqeeze in a simple test case. I can help with setting up a testing environment

vsphere/resource_vsphere_host.go Show resolved Hide resolved
vsphere/resource_vsphere_host.go Outdated Show resolved Hide resolved
vsphere/resource_vsphere_host.go Show resolved Hide resolved
vsphere/resource_vsphere_host.go Outdated Show resolved Hide resolved
website/docs/r/host.html.markdown Show resolved Hide resolved
@burnsjared0415 burnsjared0415 force-pushed the feature/added-ntpd-support-for-resource_vsphere_host branch from 668bcee to 7ea5766 Compare July 3, 2024 16:32
@burnsjared0415 burnsjared0415 force-pushed the feature/added-ntpd-support-for-resource_vsphere_host branch from 7ea5766 to 72ca607 Compare July 8, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenthirtyam tenthirtyam tenthirtyam requested changes

@spacegospod spacegospod spacegospod left review comments

@iBrandyJackson iBrandyJackson Awaiting requested review from iBrandyJackson

Requested changes must be addressed to merge this pull request.

Assignees

@burnsjared0415 burnsjared0415

Labels
area/host Area: Host documentation Type: Documentation enhancement Type: Enhancement needs-review Status: Pull Request Needs Review provider Type: Provider
Projects
None yet
Milestone
v2.8.3
Development

Successfully merging this pull request may close these issues.

Add support to manage ntpd setting on ESXi hosts
3 participants
@burnsjared0415 @tenthirtyam @spacegospod