Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support endPort on network policy resource #2494

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tostieme
Copy link

@tostieme tostieme commented May 18, 2024

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccKubernetesNetworkPolicyV1_basic'
==> Checking that code complies with gofmt requirements...
go vet ./...
TF_ACC=1 go test "/Users/tostieme/go/src/github.com/hashicorp/terraform-provider-kubernetes/kubernetes" -v -vet=off -run=TestAccKubernetesNetworkPolicyV1_basic -parallel 8 -timeout 3h
=== RUN   TestAccKubernetesNetworkPolicyV1_basic
=== PAUSE TestAccKubernetesNetworkPolicyV1_basic
=== CONT  TestAccKubernetesNetworkPolicyV1_basic
--- PASS: TestAccKubernetesNetworkPolicyV1_basic (13.17s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes      13.849s

Release Note

Release note for CHANGELOG:

`resource/resource_kubernetes_network_policy_v1`: add support for `end_port`

References

Closes #2455

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Copy link

hashicorp-cla-app bot commented May 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Tobias Stiemer seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@tostieme tostieme marked this pull request as ready for review May 18, 2024 13:57
@tostieme tostieme requested a review from a team as a code owner May 18, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support endPort in kubernetes_network_policy
1 participant