Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Allow CRD missing error when computing manifest #1396

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MockyJoke
Copy link

@MockyJoke MockyJoke commented Jun 28, 2024

Description

  • This PR aims to fix an issue related to the experimental manifest feature.

Issue

When the experimental manifest feature is enabled and deploying two charts with a CRD dependency between them (e.g., Chart A installs a new CRD in its manifest, and Chart B declares objects of that CRD), performing terraform plan raises an error. The error occurs in Chart B, stating that the CRD is not yet installed, thus unable to compute its final manifest.

This is not inherently an issue, as the two charts can be installed successfully as long as Chart A is installed before Chart B. This dependency can be managed by setting the depends_on property for Chart B.

Proposed Solution

  • Modify the handling of errors when the manifest feature is enabled to allow such errors to not break the planning process.

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@MockyJoke MockyJoke requested a review from a team as a code owner June 28, 2024 02:29
Copy link

hashicorp-cla-app bot commented Jun 28, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@MockyJoke MockyJoke changed the title Allow CRD missing error when computing manifest (fix) Allow CRD missing error when computing manifest Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant