Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated migrate_traffic description in google_app_engine_service_split_traffic resource #9896

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thedmeyer
Copy link
Contributor

Updating description of the migrate_traffic variable to be more clear on it's purpose and be in line with GCP documentation.

See: https://cloud.google.com/appengine/docs/admin-api/migrating-splitting-traffic

@pjeannet
Copy link

Hello, found this PR while looking at existing issues with migrate_traffic. You could also add that it won't work with flex environment (I tried to use it and got Traffic migration does not support App Engine Flexible Environment.).
I also noticed that it's not really optionnal as if we don't set it to false then we get Invalid value at 'migrate_traffic' (TYPE_BOOL), \"\".

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there - this is correct, but as you can see at the top of this file, this code is autogenerated. Would you mind making the change at the source? That's https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/products/appengine/api.yaml#L1437.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants