Fix error drop column with reserved word #20751
Conversation
Signed-off-by: kataoka-ayumu <[email protected]>
|
** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you! |
| for _, column := range droppedColumns { | ||
| backquotedDroppedColumns = append(backquotedDroppedColumns, fmt.Sprintf("`%s`", column)) | ||
| } | ||
| droppedColumnsString := strings.Join(backquotedDroppedColumns, ", DROP COLUMN ") |
There was a problem hiding this comment.
If droppedColumns = []string("column1", "column2") ,
backquotedDroppedColumns = []string("`column1`", "`column2`")
droppedColumnsString = "`column1`, DROP COLUMN `column2`"
dropColumnsDDL = "ALTER TABLE <table_id> DROP Column `column1`, DROP COLUMN `column2`"
There was a problem hiding this comment.
This PR should be opened on the magic-modules repo instead as it's the code that generates the terraform-provider-google repo.
The exact file you would edit can be found here: https://github.com/GoogleCloudPlatform/magic-modules/blob/37e4abb059553f92e3eb4960ec0a2188a3cef77a/mmv1/third_party/terraform/services/bigquery/resource_bigquery_table.go.tmpl#L2086-L2103
I'll be closing this PR, please make the changes in magic-modules!
fix: #20750
Backquoted the column names when constructing the DROP COLUMN query