keyvault client: fix concurrent write/read to keyvault cache

[wuxu92]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The keysmith locker and lock locker map cannot ensure that all operations on the cache map are properly locked. In Go's standard map structure, you cannot lock a specific key and operate on it separately; the entire map must be locked. This PR removes the lock map, as the provider runs in client mode and does not require high concurrency. Therefore, a global lock is sufficient for performance (and we use RWLocker to mitigate the impact).

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

The failed cases are not related to this change:

--- PASS: TestAccKeyVault_softDeleteRecoveryDisabled (270.31s)
--- PASS: TestAccKeyVault_purgeProtectionAndSoftDeleteEnabled (302.57s)
--- PASS: TestAccKeyVault_purgeProtectionEnabled (361.52s)
--- PASS: TestAccKeyVault_purgeProtectionAttemptToDisable (389.47s)
--- FAIL: TestAccKeyVault_accessPolicyUpperLimit (444.21s)
--- PASS: TestAccKeyVault_publicNetworkAccessDisabled (798.33s)
--- PASS: TestAccKeyVault_complete (856.00s)
--- PASS: TestAccKeyVault_basic (868.80s)
--- FAIL: TestAccKeyVault_networkAclsAllowed (923.57s)
--- FAIL: TestAccKeyVault_disappears (927.44s)
--- FAIL: TestAccKeyVault_purgeProtectionViaUpdate (951.40s)
--- FAIL: TestAccKeyVault_update (954.70s)
--- PASS: TestAccKeyVault_upgradeSKU (964.68s)
--- PASS: TestAccKeyVault_softDelete (1034.14s)
--- PASS: TestAccKeyVault_networkAcls (1102.14s)
--- PASS: TestAccKeyVault_justCert (835.60s)
--- FAIL: TestAccKeyVault_requiresImport (1267.50s)
--- PASS: TestAccKeyVault_softDeleteRecovery (1036.02s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_keyvault_xx - Fix crash during concurrent read/write to cache map. [fatal error: concurrent map read and map write (succeeded on retrying apply) #28274]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #28274