Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_backup_protected_vm - integrate with azurerm_data_protection_resource_guard #28306

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Dec 17, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The payload during deletion should contain guard operation ids.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
❯❯ tftest recoveryservices TestAccBackupProtectedVm_
=== RUN   TestAccBackupProtectedVm_basic
=== PAUSE TestAccBackupProtectedVm_basic
=== RUN   TestAccBackupProtectedVm_requiresImport
=== PAUSE TestAccBackupProtectedVm_requiresImport
=== RUN   TestAccBackupProtectedVm_separateResourceGroups
=== PAUSE TestAccBackupProtectedVm_separateResourceGroups
=== RUN   TestAccBackupProtectedVm_updateBackupPolicyId
=== PAUSE TestAccBackupProtectedVm_updateBackupPolicyId
=== RUN   TestAccBackupProtectedVm_updateDiskExclusion
=== PAUSE TestAccBackupProtectedVm_updateDiskExclusion
=== RUN   TestAccBackupProtectedVm_removeVM
=== PAUSE TestAccBackupProtectedVm_removeVM
=== RUN   TestAccBackupProtectedVm_protectionStopped
=== PAUSE TestAccBackupProtectedVm_protectionStopped
=== RUN   TestAccBackupProtectedVm_protectionStoppedOnDestroy
=== PAUSE TestAccBackupProtectedVm_protectionStoppedOnDestroy
=== RUN   TestAccBackupProtectedVm_protectionStoppedOnDestroyWithGuard
=== PAUSE TestAccBackupProtectedVm_protectionStoppedOnDestroyWithGuard
=== RUN   TestAccBackupProtectedVm_recoverSoftDeletedVM
=== PAUSE TestAccBackupProtectedVm_recoverSoftDeletedVM
=== CONT  TestAccBackupProtectedVm_basic
=== CONT  TestAccBackupProtectedVm_removeVM
=== CONT  TestAccBackupProtectedVm_protectionStoppedOnDestroyWithGuard
=== CONT  TestAccBackupProtectedVm_updateBackupPolicyId
=== CONT  TestAccBackupProtectedVm_updateDiskExclusion
=== CONT  TestAccBackupProtectedVm_separateResourceGroups
=== CONT  TestAccBackupProtectedVm_recoverSoftDeletedVM
=== CONT  TestAccBackupProtectedVm_protectionStoppedOnDestroy
--- PASS: TestAccBackupProtectedVm_protectionStoppedOnDestroyWithGuard (517.86s)
=== CONT  TestAccBackupProtectedVm_requiresImport
--- PASS: TestAccBackupProtectedVm_removeVM (582.72s)
=== CONT  TestAccBackupProtectedVm_protectionStopped
--- PASS: TestAccBackupProtectedVm_protectionStoppedOnDestroy (597.21s)
--- PASS: TestAccBackupProtectedVm_separateResourceGroups (675.53s)
--- PASS: TestAccBackupProtectedVm_basic (747.63s)
--- PASS: TestAccBackupProtectedVm_updateDiskExclusion (869.94s)
--- PASS: TestAccBackupProtectedVm_recoverSoftDeletedVM (948.87s)
--- PASS: TestAccBackupProtectedVm_updateBackupPolicyId (1026.36s)
--- PASS: TestAccBackupProtectedVm_requiresImport (615.05s)
--- PASS: TestAccBackupProtectedVm_protectionStopped (880.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/recoveryservices	1463.513s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_backup_protected_vm - integrate with azurerm_data_protection_resource_guard [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #28264

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@@ -108,43 +107,6 @@ func TestAccBackupProtectedVm_updateBackupPolicyId(t *testing.T) {
ResourceName: fBackupPolicyResourceName,
Config: r.withBasePolicy(data),
},
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these 2 steps cause failure

    testcase.go:173: Step 4/4 error: Pre-apply plan check(s) failed:
        azurerm_backup_protected_vm.test - Resource not found in plan ResourceChanges

})
}

func TestAccBackupProtectedVm_updateVault(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update vault related info will force a new resource to be created

@ziyeqf ziyeqf marked this pull request as ready for review December 17, 2024 08:19
@ziyeqf ziyeqf requested a review from a team as a code owner December 17, 2024 08:19
@ziyeqf
Copy link
Contributor Author

ziyeqf commented Dec 18, 2024

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vm_backup_stop_protection_and_retain_data_on_destroy not working
1 participant