-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_backup_protected_vm
- integrate with azurerm_data_protection_resource_guard
#28306
Open
ziyeqf
wants to merge
5
commits into
hashicorp:main
Choose a base branch
from
ziyeqf:issue/28264
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+559
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on_resource_guard`
1 task
ziyeqf
commented
Dec 17, 2024
@@ -108,43 +107,6 @@ func TestAccBackupProtectedVm_updateBackupPolicyId(t *testing.T) { | |||
ResourceName: fBackupPolicyResourceName, | |||
Config: r.withBasePolicy(data), | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these 2 steps cause failure
testcase.go:173: Step 4/4 error: Pre-apply plan check(s) failed:
azurerm_backup_protected_vm.test - Resource not found in plan ResourceChanges
ziyeqf
commented
Dec 17, 2024
}) | ||
} | ||
|
||
func TestAccBackupProtectedVm_updateVault(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update vault related info will force a new resource to be created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
The payload during deletion should contain guard operation ids.
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_backup_protected_vm
- integrate withazurerm_data_protection_resource_guard
[GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #28264
Note
If this PR changes meaningfully during the course of review please update the title and description as required.