Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_container_registry - remove ConfigModeAttr for 4.0 #26547

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

stephybun
Copy link
Member

@stephybun stephybun commented Jul 5, 2024

Community Note

  • Please vote on this PR by adding a 馃憤 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Removed ConfigModeAttr from network_rule_set, also extends some of the tests to ensure that downgrading the sku is still possible without ConfigModeAttr.

Testing

image

Test results in 4.0 mode

--- PASS: TestAccContainerRegistry_basicManagedPremium (138.83s)
--- PASS: TestAccContainerRegistry_basicManagedStandard (163.46s)
--- PASS: TestAccContainerRegistry_networkRuleBypassOption (165.31s)
--- PASS: TestAccContainerRegistry_zoneRedundancy (166.06s)
--- PASS: TestAccContainerRegistry_requiresImport (199.71s)
--- PASS: TestAccContainerRegistry_basic (203.37s)
--- PASS: TestAccContainerRegistry_anonymousPull (211.27s)
--- PASS: TestAccContainerRegistry_complete (113.53s)
--- PASS: TestAccContainerRegistry_geoReplicationRegionEndpoint (221.55s)
--- PASS: TestAccContainerRegistry_networkAccessProfileUpdate (229.23s)
--- PASS: TestAccContainerRegistry_dataEndpoint (230.05s)
--- PASS: TestAccContainerRegistry_basic2Premium2basic (239.94s)
--- PASS: TestAccContainerRegistry_networkAccessProfileIp (261.36s)
--- PASS: TestAccContainerRegistry_geoReplicationZoneRedundancy (280.18s)
--- PASS: TestAccContainerRegistry_update (373.14s)
--- PASS: TestAccContainerRegistry_encryption (380.75s)
--- PASS: TestAccContainerRegistry_geoReplicationLocation (424.34s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/containers    427.181s

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Closes #20721

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@github-actions github-actions bot added the size/M label Jul 5, 2024
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephybun stephybun merged commit 8b6c739 into main Jul 8, 2024
31 checks passed
@stephybun stephybun deleted the f/configmodeattr-container-regitry branch July 8, 2024 07:58
@github-actions github-actions bot added this to the v3.112.0 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic block with for_each within network_rule_set inside azurerm_container_registry won't work
2 participants