Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_network - extend subnet block #26533

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

stephybun
Copy link
Member

@stephybun stephybun commented Jul 3, 2024

Community Note

  • Please vote on this PR by adding a 馃憤 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR removes Computed and ConfigModeAttr on the subnet block in 4.0 and also adds the following properties to it:

  • default_outbound_access_enabled
  • delegation
  • private_endpoint_network_policies
  • private_link_service_network_policies_enabled
  • route_table_id
  • service_endpoints
  • service_endpoint_policy_ids

Testing

image

Test results in 4.0 mode:

--- PASS: TestAccVirtualNetwork_disappears (83.24s)
--- PASS: TestAccVirtualNetwork_requiresImport (93.90s)
--- PASS: TestAccVirtualNetwork_subnet (137.31s)
--- PASS: TestAccVirtualNetwork_deleteSubnet (145.86s)
--- PASS: TestAccVirtualNetwork_bgpCommunity (160.34s)
--- PASS: TestAccVirtualNetwork_complete (162.25s)
--- PASS: TestAccVirtualNetwork_ddosProtectionPlan (162.62s)
--- PASS: TestAccVirtualNetwork_basicUpdated (169.71s)
--- PASS: TestAccVirtualNetwork_basic (172.02s)
--- PASS: TestAccVirtualNetwork_withTags (174.45s)
--- PASS: TestAccVirtualNetwork_subnetRouteTable (181.92s)
--- PASS: TestAccVirtualNetwork_edgeZone (186.37s)
--- PASS: TestAccVirtualNetwork_updateFlowTimeoutInMinutes (210.34s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/network       213.306s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Closes #3917
Closes #6382
Closes #18107
Supersedes #24972

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun - LGTM 馃

@stephybun stephybun requested a review from manicminer July 4, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants