Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_servicebus_* - remove optional and computed in 4.0 and rename enable_* to *_enabled #26479

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

catriona-m
Copy link
Member

@catriona-m catriona-m commented Jun 26, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR removes optional and computed properties in servicebus and renames enable_* to *_enabled in azurem_servicebus_namespace, azurem_servicebus_queue, azurem_servicebus_topic and azurem_servicebus_subscription.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Tests passing aside from tests currently failing in main

image

@catriona-m catriona-m marked this pull request as draft June 26, 2024 15:08
@catriona-m catriona-m marked this pull request as ready for review July 2, 2024 17:21
@catriona-m catriona-m requested a review from a team July 2, 2024 17:21
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @catriona-m, aside from the failing lint check LGTM 🐊

@catriona-m catriona-m merged commit 82badd4 into main Jul 9, 2024
30 checks passed
@catriona-m catriona-m deleted the cm/ocservicebus branch July 9, 2024 11:29
@github-actions github-actions bot added this to the v3.112.0 milestone Jul 9, 2024
catriona-m added a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants