Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

managementgroups - migrate to hashicorp/go-azure-sdk #26430

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Jun 21, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Ref: #21930 (comment)

Migrate to hashicorp/go-azure-sdk, as preparation to migrate to typed resources.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
=== RUN   TestAccManagementGroupDataSource_basicByName
=== PAUSE TestAccManagementGroupDataSource_basicByName
=== CONT  TestAccManagementGroupDataSource_basicByName
--- PASS: TestAccManagementGroupDataSource_basicByName (93.78s)
=== RUN   TestAccManagementGroupDataSource_basicByDisplayName
=== PAUSE TestAccManagementGroupDataSource_basicByDisplayName
=== CONT  TestAccManagementGroupDataSource_basicByDisplayName
--- PASS: TestAccManagementGroupDataSource_basicByDisplayName (76.35s)
=== RUN   TestAccManagementGroupDataSource_nestedManagementGroup
=== PAUSE TestAccManagementGroupDataSource_nestedManagementGroup
=== CONT  TestAccManagementGroupDataSource_nestedManagementGroup
--- PASS: TestAccManagementGroupDataSource_nestedManagementGroup (175.83s)
=== RUN   TestAccManagementGroup_basic
=== PAUSE TestAccManagementGroup_basic
=== CONT  TestAccManagementGroup_basic
--- PASS: TestAccManagementGroup_basic (83.16s)
=== RUN   TestAccManagementGroup_requiresImport
=== PAUSE TestAccManagementGroup_requiresImport
=== CONT  TestAccManagementGroup_requiresImport
--- PASS: TestAccManagementGroup_requiresImport (79.22s)
=== RUN   TestAccManagementGroup_nested
=== PAUSE TestAccManagementGroup_nested
=== CONT  TestAccManagementGroup_nested
--- PASS: TestAccManagementGroup_nested (137.68s)
=== RUN   TestAccManagementGroup_multiLevel
=== PAUSE TestAccManagementGroup_multiLevel
=== CONT  TestAccManagementGroup_multiLevel
--- PASS: TestAccManagementGroup_multiLevel (173.03s)
=== RUN   TestAccManagementGroup_multiLevelUpdated
=== PAUSE TestAccManagementGroup_multiLevelUpdated
=== CONT  TestAccManagementGroup_multiLevelUpdated
--- PASS: TestAccManagementGroup_multiLevelUpdated (224.35s)
=== RUN   TestAccManagementGroup_withName
=== PAUSE TestAccManagementGroup_withName
=== CONT  TestAccManagementGroup_withName
--- PASS: TestAccManagementGroup_withName (81.98s)
=== RUN   TestAccManagementGroup_updateName
=== PAUSE TestAccManagementGroup_updateName
=== CONT  TestAccManagementGroup_updateName
--- PASS: TestAccManagementGroup_updateName (140.20s)
=== RUN   TestAccManagementGroup_withSubscriptions
=== PAUSE TestAccManagementGroup_withSubscriptions
=== CONT  TestAccManagementGroup_withSubscriptions
--- PASS: TestAccManagementGroup_withSubscriptions (139.15s)
=== RUN   TestAccManagementGroupSubscriptionAssociation
--- PASS: TestAccManagementGroupSubscriptionAssociation (325.56s)
=== RUN   TestAccManagementGroupSubscriptionAssociation/Resource
    --- PASS: TestAccManagementGroupSubscriptionAssociation/Resource (325.56s)
=== RUN   TestAccManagementGroupSubscriptionAssociation/Resource/basic
        --- PASS: TestAccManagementGroupSubscriptionAssociation/Resource/basic (164.06s)
=== RUN   TestAccManagementGroupSubscriptionAssociation/Resource/requiresImport
        --- PASS: TestAccManagementGroupSubscriptionAssociation/Resource/requiresImport (161.50s)
PASS

Process finished with the exit code 0

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • managementgroups - migrate to hashicorp/go-azure-sdk [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@jkroepke
Copy link
Contributor Author

jkroepke commented Jul 1, 2024

ref: hashicorp/go-azure-sdk#1025

@tombuildsstuff
Copy link
Member

@jkroepke FYI I've merged the upstream change, once the SDK is regenerated I'm going to look to incorporate the rename into #26502 (since there's some other renames in that branch, too); but once that branch is in it should be possible to rebase this PR atop and pick up the rename(s)

@jkroepke jkroepke marked this pull request as draft July 1, 2024 08:03
@jkroepke
Copy link
Contributor Author

jkroepke commented Jul 1, 2024

Hey @tombuildsstuff ,

in the mention PR #26502 I do not see any managementgroups related changed.

@jkroepke jkroepke marked this pull request as ready for review July 1, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants