Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(26428): data azurerm_network_service_tags AzureFrontDoor.Frontend support #26429

Merged

Conversation

hilariocoelho
Copy link
Contributor

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Added support for service with . (like AzureFrontDoor.Frontend)

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
$ make acctests SERVICE='network' TESTARGS='-run=TestAccDataSourceAzureRMServiceTags_'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/network -run=TestAccDataSourceAzureRMServiceTags_ -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceAzureRMServiceTags_basic
=== PAUSE TestAccDataSourceAzureRMServiceTags_basic
=== RUN   TestAccDataSourceAzureRMServiceTags_tagName
=== PAUSE TestAccDataSourceAzureRMServiceTags_tagName
=== RUN   TestAccDataSourceAzureRMServiceTags_region
=== PAUSE TestAccDataSourceAzureRMServiceTags_region
=== RUN   TestAccDataSourceAzureRMServiceTags_AzureFrontDoor
=== PAUSE TestAccDataSourceAzureRMServiceTags_AzureFrontDoor
=== RUN   TestAccDataSourceAzureRMServiceTags_AzureFrontDoorBackend
=== PAUSE TestAccDataSourceAzureRMServiceTags_AzureFrontDoorBackend
=== RUN   TestAccDataSourceAzureRMServiceTags_AzureFrontDoorFrontend
=== PAUSE TestAccDataSourceAzureRMServiceTags_AzureFrontDoorFrontend
=== RUN   TestAccDataSourceAzureRMServiceTags_AzureFrontDoorFirstParty
=== PAUSE TestAccDataSourceAzureRMServiceTags_AzureFrontDoorFirstParty
=== CONT  TestAccDataSourceAzureRMServiceTags_basic
=== CONT  TestAccDataSourceAzureRMServiceTags_AzureFrontDoorBackend
=== CONT  TestAccDataSourceAzureRMServiceTags_region
=== CONT  TestAccDataSourceAzureRMServiceTags_AzureFrontDoor
=== CONT  TestAccDataSourceAzureRMServiceTags_tagName
=== CONT  TestAccDataSourceAzureRMServiceTags_AzureFrontDoorFirstParty
=== CONT  TestAccDataSourceAzureRMServiceTags_AzureFrontDoorFrontend
--- PASS: TestAccDataSourceAzureRMServiceTags_basic (27.74s)
--- PASS: TestAccDataSourceAzureRMServiceTags_region (41.33s)
--- PASS: TestAccDataSourceAzureRMServiceTags_AzureFrontDoorFrontend (84.89s)
--- PASS: TestAccDataSourceAzureRMServiceTags_AzureFrontDoorFirstParty (93.53s)
--- PASS: TestAccDataSourceAzureRMServiceTags_AzureFrontDoor (102.18s)
--- PASS: TestAccDataSourceAzureRMServiceTags_AzureFrontDoorBackend (111.46s)
--- PASS: TestAccDataSourceAzureRMServiceTags_tagName (148.55s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/network       148.566s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_network_service_tags - data support for AzureFrontDoor.Backend, AzureFrontDoor.FirstParty and AzureFrontDoor.Frontend tags

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #26428

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hilariocoelho LGTM 👍

@stephybun stephybun merged commit bfe695e into hashicorp:main Jul 8, 2024
31 checks passed
@github-actions github-actions bot added this to the v3.112.0 milestone Jul 8, 2024
stephybun added a commit that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_network_service_tags does not work for globally deployed resources (e.g. FrontDoor)
2 participants