Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: recommend dmidecode for rpm and deb packages #24765

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

pkazmierczak
Copy link
Contributor

Add dmidecode to "recommended" dependencies to improve UX on Linux machines that install Nomad via official packages.

Resolves #19382
Internal ref: https://hashicorp.atlassian.net/browse/NET-10747

@pkazmierczak pkazmierczak requested a review from jrasell December 31, 2024 14:55
@pkazmierczak pkazmierczak self-assigned this Dec 31, 2024
@pkazmierczak pkazmierczak requested review from a team as code owners December 31, 2024 14:55
@pkazmierczak pkazmierczak added backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.9.x backport to 1.9.x release line labels Dec 31, 2024
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pkazmierczak!

@pkazmierczak pkazmierczak merged commit f01c8aa into main Jan 3, 2025
40 checks passed
@pkazmierczak pkazmierczak deleted the f-packaging-dmidecode branch January 3, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.9.x backport to 1.9.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packaging: Add dmidecode as a Suggested / Recommended package to Nomad's Linux packaging manifest.
2 participants