[ui] Show ALL regions' leaders when viewing servers route #24723
Conversation
philrenaud
force-pushed
the
24309-parity-between-uiservers-and-nomad-server-members
branch
from
16ad689 to
98d0de0
Compare
| @tracked isLeader = false; | ||
|
|
||
| @action async checkForLeadership() { | ||
| const leaders = await this.system.leaders; | ||
| this.isLeader = leaders.includes(this.rpcAddr); | ||
| return this.isLeader; |
There was a problem hiding this comment.
using tracked is more idiomatic than the isLeader getter in Ember Octane. And since service getters (like this.get('system.leader....) was the thing holding it back as a classic model, removed the @classic tag as well.
| .authorizedRequest(`/${namespace}/status/leader?region=${region}`) | ||
| .then((res) => res.json()); | ||
| }) | ||
| ); |
There was a problem hiding this comment.
Best as I can tell, the only thing that uses system.leader was the servers page, which is now using .leaders instead. Removed the old one.
There was a problem hiding this comment.
What's the ${namespace} referring to here? v1?
There was a problem hiding this comment.
Yeah, v1! It's my third favourite among the three ways we use the term "namespace" in the UI.
It imports from
nomad/ui/app/adapters/application.js
Line 15 in 0324e78
|
|
||
| beforeModel() { | ||
| return this.get('system.leader'); | ||
| } |
There was a problem hiding this comment.
As best as I can tell, this was accidentally left in here by copying the servers route page ~9 years ago.
| @text={{if | ||
| this.agent.isLeader | ||
| (if | ||
| this.agent.system.shouldShowRegions | ||
| (concat "True" " (" this.agent.region ")") | ||
| "True" | ||
| ) | ||
| "False" | ||
| }} |
There was a problem hiding this comment.
Funky formatting, but:
- If not a leader, just show "False"
- If a leader, show "True"
- If there are multiple regions at play, show region name in parentheses.
Resolves #24309
In a multi-region setup:
In a single-region setup:
