plan: inform user if a deployment will be created #24646
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just a proof of concept because the plan output when deployments are involved is a bit non-obvious. When updating a job with count=3, the plan will only show the first step of the deployment (as determined by update.max_parallel):
This hack plumbs through whether a deployment was attached to the plan. Obviously the output and field names need improving. For backward compatibility we probably shouldn't output anything if there isn't a deployment, but this PoC includes a message for either case for ease of testing/demonstration.
Testing & Reproduction steps
nomad job run -var dur=60 sleeper.nomad.hcl
nomad job plan -var dur=900 sleeper.nomad.hcl
Contributor Checklist
changelog entry using the
make cl
command.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.