Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: Add dmidecode as a Suggested / Recommended package to Nomad's Linux packaging manifest. #19382

Closed
shoenig opened this issue Dec 8, 2023 · 3 comments · Fixed by #24765
Assignees
Milestone

Comments

@shoenig
Copy link
Member

shoenig commented Dec 8, 2023

Add dmidecode as a Suggested / Recommended package to Nomad's Linux packaging manifest.

Nomad 1.7 and later relies on the dmidecode command being available particularly in virtualized environments like Amazon EC2 for the detection of CPU performance data.

Not having this as part of the Linux packaging creates a bad UX for first starting up a Nomad 1.7 agent in these environments, e.g.

#19343
#19371

@shoenig shoenig added this to the 1.7.x milestone Dec 8, 2023
@apollo13
Copy link
Contributor

apollo13 commented Dec 8, 2023

I'd recommend (pun intended) to put it into the recommended section and not suggested. Recommended is usually (not always though) installed by default whereas suggested is usually not installed and also not seen by the user. Then again if this is only required for virtualized systems it might not make sense to install by default but solely error out in the nomad agent and as such communicating the problem clearly to the user. On the other hand I'd imagine virtual machines are probably more common than bare metal nowadays for nomad, so it still might make sense to install dmidecode by default via a dependency.

@ahjohannessen
Copy link

Flatcar Linux does not seem to have dmidecode - Fedora CoreOS can get it via rpm-ostree. Wonder how I should go about this with my Flatcar machines.

@MorphBonehunter
Copy link

I'm not convinced that installing dmidecode should be adviced as this could lead to suboptimal MHz readings (#19468) in virtual machine environments. So that's maybe also a point to rethink reopening #18213.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants