Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static IP, IPv6 and MAC addresses with Podman >=4.0.0 #359

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zandeez
Copy link

@zandeez zandeez commented Jul 2, 2024

Resolve #293 and #358 adding ipv6_address, ipv4_address, static_ips and static_mac options for podman tasks.

Podman API version checks whether to set the properties directly or whether to use the new PerNetworkOptions framework.

ipv6_address and ipv4_address are provided for backwards compatibility, and for compatibility with docker. For Podman 4.0.0 these are merged into static_ips and sent as a PerNetorkOptions entry for the default network.

Copy link

hashicorp-cla-app bot commented Jul 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

…ress, static_ips and static_mac options for podman tasks.

Podman API version checks whether to set the properties directly or whether to use the new PerNetworkOptions framework.

ipv6_address and ipv4_address are provided for backwards compatibility, and for compatibility with docker. For Podman 4.0.0 these are merged into static_ips and sent as a PerNetorkOptions entry for the default network.
Added API version check, static mac support, new array-based option for static IPs to match the podman API
@zandeez zandeez requested a review from a team as a code owner July 15, 2024 20:39
@Juanadelacuesta
Copy link
Member

Hello @zandeez, thank you for submitting this PR, My colleagues @shoenig or @gulducat have some expertise on that system, so I’d like to see what they might think of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add mac_address parameter
2 participants