Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QT-570] Add support for running enos with providers running in debug mode #98

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[QT-570] Add support for running enos with providers running in debug mode #98

wants to merge 2 commits into from

Conversation

mikebaum
Copy link
Contributor

@mikebaum mikebaum commented Jun 2, 2023

Updated the apply, destroy, init, plan, and show runner actions to support the using providers running in debug mode as configured by the TF_REATTACH_PROVIDERS environment variable.

Checklist

  • The commit message includes an explanation of the changes
  • Manual validation of the changes have been performed (if possible)
  • New or modified code has requisite test coverage (if possible)
  • I have performed a self-review of the changes
  • I have made necessary changes and/or pull requests for documentation
  • I have written useful comments in the code

@mikebaum mikebaum requested a review from a team as a code owner June 2, 2023 18:20
@mikebaum mikebaum added the changelog/feat New feature or enhancement. Will be included in "New Features" category in release notes. label Jun 2, 2023
joshbrand
joshbrand suggested changes Jun 2, 2023
View reviewed changes
internal/operation/terraform/terraform.go
// UnMarshallReattachInfo unmarshalls the reattach providers configuration string into a tfexec.ReattachOption.
func UnMarshallReattachInfo(reattachInfo string) (*tfexec.ReattachOption, error) {
var info tfexec.ReattachInfo
err := json.Unmarshal([]byte(reattachInfo), &info)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is Unmarshal but you've used Unmarshall in the other func names, we should be consistent (also english is terrible)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbrand joshbrand joshbrand approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
changelog/feat New feature or enhancement. Will be included in "New Features" category in release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikebaum @joshbrand