chore(deps): update module go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to v0.44.0 [security] (master) #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
…n/net/http/otelhttp to v0.44.0 [security]
|
|
To fix the error in #135 (comment), needs to update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v0.20.0->v0.44.0GitHub Vulnerability Alerts
CVE-2023-45142
Summary
This handler wrapper https://github.com/open-telemetry/opentelemetry-go-contrib/blob/5f7e6ad5a49b45df45f61a1deb29d7f1158032df/instrumentation/net/http/otelhttp/handler.go#L63-L65
out of the box adds labels
http.user_agenthttp.methodthat have unbound cardinality. It leads to the server's potential memory exhaustion when many malicious requests are sent to it.
Details
HTTP header User-Agent or HTTP method for requests can be easily set by an attacker to be random and long. The library internally uses httpconv.ServerRequest that records every value for HTTP method and User-Agent.
PoC
Send many requests with long randomly generated HTTP methods or/and User agents (e.g. a million) and observe how memory consumption increases during it.
Impact
In order to be affected, the program has to configure a metrics pipeline, use otelhttp.NewHandler wrapper, and does not filter any unknown HTTP methods or User agents on the level of CDN, LB, previous middleware, etc.
Others
It is similar to already reported vulnerabilities
Workaround for affected versions
As a workaround to stop being affected otelhttp.WithFilter() can be used, but it requires manual careful configuration to not log certain requests entirely.
For convenience and safe usage of this library, it should by default mark with the label
unknownnon-standard HTTP methods and User agents to show that such requests were made but do not increase cardinality. In case someone wants to stay with the current behavior, library API should allow to enable it.The other possibility is to disable HTTP metrics instrumentation by passing
otelhttp.WithMeterProvideroption withnoop.NewMeterProvider.Solution provided by upgrading
In PR https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277, released with package version 0.44.0, the values collected for attribute
http.request.methodwere changed to be restricted to a set of well-known values and other high cardinality attributes were removed.References
Release Notes
open-telemetry/opentelemetry-go-contrib (go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp)
v0.24.0Compare Source
0.24.0 - 2021-09-21
Update dependency on the
go.opentelemetry.io/otelproject tov1.0.0.v0.23.0Compare Source
0.23.0 - 2021-09-09
Added
WithoutSubSpans,WithRedactedHeaders,WithoutHeaders, andWithInsecureHeadersoptions forotelhttptrace.NewClientTrace. (#879)Changed
go.opentelemetry.io/contrib/propagatorsmodule intob3,jaeger,otmodules. (#985)otelmongodbspan attributes, name and span status now conform to specification. (#769)go.opentelemetry.io/contrib/detectors/awsto a separate EC2 resource detector modulego.opentelemetry.io/contrib/detectors/aws/ec2(#1017)cloud.providerandcloud.platformto AWS detectors. (#1043)otelhttptrace.NewClientTracenow redacts known sensitive headers by default. (#879)Fixed
otelhttp.TransportwhenRoundTripfails with an error. (#950)v0.22.0Compare Source
Added
zpagesspan processor. (#894)Changed
b3.B3type has been removed.b3.New()andb3.WithInjectEncoding(encoding)are added to replace it. (#868)Fixed
otelsarama.WrapAsyncProducer.The
messaging.message_idandmessaging.kafka.partitionattributes are now not set if a message was not processed. (#754) (#755) (#881)otelsarama.WrapAsyncProducerso that the messages from theErrorschannel contain the originalMetadata. (#754)v0.21.0Compare Source
0.21.0 - 2021-06-18
Fixed
otelginandotelmacaron. (#767)Changed
Removed
otelmongodbconfiguration and span attributes. (#763)Configuration
📅 Schedule: Branch creation - "" in timezone Asia/Taipei, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.