Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upgrade): clean up image with crictl #7203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

starbops
Copy link
Member

@starbops starbops commented Dec 19, 2024

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Problem:

We used ctr to remove container images initially. But that's not thorough.

Solution:

Replace the use of ctr i rm with crictl rmi.

Related Issue:

#6691

Test plan:

  1. Prepare a Harvester cluster in v1.4.0
  2. Prepare a customized build of Harvester ISO image containing this fix
  3. Get the before-upgrade image list on each node with crictl images
  4. Upgrade the cluster with the ISO image
  5. After the upgrade succeed, collect the after-upgrade image list on each node
  6. Besides, the result of crictl images should not contain bunch of <none> lines (please refer to [BUG] Image lists looks weird after upgrade purging images #6691 (comment) for example)
  7. Compare the two lists. Images exist in v1.4.0 but not in the customized build should be removed.

@starbops starbops marked this pull request as ready for review December 19, 2024 06:23
@bk201 bk201 requested a review from FrankYang0529 December 26, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants