Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add content about vmimage backup #613

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FrankYang0529
Copy link
Member

Copy link

github-actions bot commented Jul 18, 2024

Name Link
🔨 Latest commit eadf877
😎 Deploy Preview https://66b08cb638c4bfa17b52dc77--harvester-preview.netlify.app

@FrankYang0529 FrankYang0529 requested a review from bk201 July 19, 2024 06:47
You must manually configure the virtual machine images with the same name on the new cluster first, otherwise the virtual machines will be failed to recover.

:::
Harvester will handle VMImage data automatically. If a volume is based on a VMImage and there is a backup for it, Harvester will automatically sync the VMImage to backup target.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's handled automatically, should we remove the section too?

#### Upload the same VM images to a new cluster

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest changing VMImage to VM image for consistency across the document.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. I addressed all comments.

@bk201 bk201 requested a review from jillian-maroket July 22, 2024 09:59
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits

docs/vm/backup-restore.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last commit brought back some wording issues.

EOF
```
Harvester automatically handles VM image data. If a volume is based on a VM image with a backup, Harvester automatically syncs the VM image with the backup target.
In a new cluster, it the VMbackup is restored to a new VM, Harvester will automatically create the VM image from the backup target.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In a new cluster, it the VMbackup is restored to a new VM, Harvester will automatically create the VM image from the backup target.
In a new cluster, if the VM backup is restored to a new VM, Harvester automatically creates the VM image from the backup target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants