Feature vm spec labels annotations #20
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls and annotations
nicolamarella
force-pushed
the
feature-vm-labels-annotations
branch
from
dc09ad9 to
5ccbca1
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a new feature in the the driver node for harvester, we would like to provide the ability to specify VM labels and annotations.
This is a feature required to be able to create node templates in Rancher for nodes running CoreOS and Ignition.
See harvester/harvester#942
Required go-harvester counterpart harvester/go-harvester#12
Important
for labels and annotations, the encoding into JSON is happening in the UI, I also worked on it -> harvester/ui-driver-harvester#9