Use apache commons for Stopwatch instead of guava #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
==========================================
- Coverage 90.16% 90.11% -0.05%
==========================================
Files 52 52
Lines 1789 1791 +2
Branches 124 125 +1
==========================================
+ Hits 1613 1614 +1
- Misses 176 177 +1
Continue to review full report at Codecov.
|
ehsanhaq
changed the title
- Use Stopwatch from apache commons instead
- Added a provided dependency on commons-lang3 3.5
|
@harsha2010 could you review this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the later version of guava from 15 onwards the constructor method of StopWatch has been deprecated, and throws following exception.
java.lang.IllegalAccessError: tried to access method com.google.common.base.Stopwatch.()V from class magellan.mapreduce.ShapeInputFormat
at magellan.mapreduce.ShapeInputFormat.computeSplits(ShapeInputFormat.scala:50)
at magellan.mapreduce.ShapeInputFormat.getSplits(ShapeInputFormat.scala:43)
at org.apache.spark.rdd.NewHadoopRDD.getPartitions(NewHadoopRDD.scala:125)
at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252)
at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:250)
at scala.Option.getOrElse(Option.scala:121)
This make it impossible to use magellan where it is required to have a later version of guava 15+
To solve this we could either use System.getTime or apache commons-lang3 which also provides a StopWatch class. This PR uses commons-lang3 StopWatch to elevate the dependency on guava.