Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play with meson #156

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Play with meson #156

wants to merge 1 commit into from

Conversation

madig
Copy link
Collaborator

@madig madig commented Jan 21, 2023

This almost does something.

khaledhosny
khaledhosny reviewed Jan 21, 2023
View reviewed changes
meson.build
'harfbuzz/src/hb-uniscribe.cc',
cpp_args: '-DHB_NO_MT=1 -DHB_EXPERIMENTAL_API=1',
include_directories: harfbuzz_includes,
)
Copy link
Collaborator

@khaledhosny khaledhosny Jan 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are going to use meson, why not use harfbuzz as a subproject (or simply as a dependency, so that #45 could be fixed as well).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the idea, but first I want to get it to actually compile. It still complains about missing hb.h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaledhosny khaledhosny khaledhosny left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madig @khaledhosny