Update mrml to 4.0.1 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ushi-as, this is not building, the api has changed in mrml v4. |
|
@jonian I see. I will look into it. |
|
@jonian it should build now. |
|
Yes, it builds successfully and the tests pass. Thank you for your contribution @ushi-as! |
|
@jonian do you have any plans on releasing it yet? |
|
@ushi-as yes I will push a new release soon, maybe today. |
|
@jonian That would be awesome. Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jonian
My team is looking forward to a bugfix in mrml 4.0.1. Is it possible to release a gem with the new version?
Cheers, ushi