Add BitTiming/BitTimingFd support to KvaserBus #1510

zariiii9003 · 2023-01-27T21:41:20Z

Can someone with a Kvaser device test KvaserBus instantiation with BitTiming and BitTimingFd?

zariiii9003 · 2023-10-14T22:57:39Z

@lumagi I'd like to include this one in 4.3. We'll start with a release candidate anyway. Could you take a look?

can/interfaces/kvaser/canlib.py

lumagi

Looks very fine to me. I think the legacy code paths should be executed just fine in case no timing parameter is passed.

can/interfaces/kvaser/canlib.py

zariiii9003 added help wanted backend:kvaser labels Jan 27, 2023

zariiii9003 added this to the Next Release milestone Jan 27, 2023

zariiii9003 force-pushed the bittiming_kvaser branch from f6da621 to 7b7242c Compare April 10, 2023 12:03

zariiii9003 mentioned this pull request May 11, 2023

kvaser constructor should allow to set more flags #1587

Open

zariiii9003 added 2 commits October 13, 2023 15:56

add BitTiming parameter to KvaserBus

3d83157

implement tests for bittiming classes with kvaser

0e39fe9

zariiii9003 force-pushed the bittiming_kvaser branch from 7b7242c to 0e39fe9 Compare October 13, 2023 13:58

zariiii9003 marked this pull request as ready for review October 14, 2023 22:56

zariiii9003 requested a review from lumagi October 14, 2023 22:56

lumagi reviewed Oct 16, 2023

View reviewed changes

can/interfaces/kvaser/canlib.py Show resolved Hide resolved

lumagi approved these changes Oct 16, 2023

View reviewed changes

can/interfaces/kvaser/canlib.py Show resolved Hide resolved

zariiii9003 added 2 commits October 16, 2023 22:18

set default number of samples to 1

daa25e1

undo last change

6cf9bf8

zariiii9003 merged commit 2d60900 into hardbyte:develop Oct 16, 2023
27 of 28 checks passed

zariiii9003 deleted the bittiming_kvaser branch January 21, 2024 12:57

Provide feedback