Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with clinical-reasoning 3.15.0 #6543

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

lukedegruchy
Copy link
Collaborator

@lukedegruchy lukedegruchy commented Dec 6, 2024

  • Add a dependency on CQL 3.19.1 in pom.xml as a temporary hack to get around a deficient CR 3.15.0, which references a deficient CQL 3.19.0
  • Introduce R4MeasureEvaluatorSingleFactory to instantiate an R4MeasureEvaluatorSingle (interface), as opposed to R4MeasureService (class)
  • Introduce R4MeasureServiceUtilsFactory to instantiate R4MeasureServiceUtils to be used by R4CollectDataService, among others
  • Ensure MeasureOperationsProvider now uses R4MeasureEvaluatorSingleFactory instead of IMeasureServiceFactory
  • Fix tests that passed erroneous reportType values that would otherwise now fail
  • Delete SubmitDataServiceR4Test, since SubmitDataServiceR4 now has a test in CR
  • Change Spring Config classes to ensure the new dependencies are injected properly
  • Ensure Spring Config returns a R4MeasureService in its implementation of R4MeasureEvaluatorSingleFactory

Closes #6550

Copy link

github-actions bot commented Dec 6, 2024

Formatting check succeeded!

@lukedegruchy lukedegruchy changed the title Integrate with clinical-reasoning master. Integrate with clinical-reasoning 3.15.0 Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.20%. Comparing base (406db33) to head (ee736f7).
Report is 127 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6543      +/-   ##
============================================
- Coverage     83.54%   83.20%   -0.34%     
- Complexity    27432    28080     +648     
============================================
  Files          1707     1772      +65     
  Lines        106185   109523    +3338     
  Branches      13397    13792     +395     
============================================
+ Hits          88710    91131    +2421     
- Misses        11750    12458     +708     
- Partials       5725     5934     +209     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukedegruchy lukedegruchy marked this pull request as ready for review December 11, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WIP: Clinical Reasoning Upgrade v3.15
1 participant