Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone: Converting project to using Typescript #25

Open
hanseaston opened this issue Aug 9, 2020 · 0 comments
Open

Milestone: Converting project to using Typescript #25

hanseaston opened this issue Aug 9, 2020 · 0 comments
Labels
enhancement enhancement on an existing feature javascript

Comments

@hanseaston
Copy link
Owner

hanseaston commented Aug 9, 2020

Right now, our project is all done in Javascript.
A better and more advanced way is to convert our project to Typescript. There's some tradeoffs, but I see this as an exercise for those who want to practice using Typescript.
There's a lot of code in this project, and converting everything to using Typescript is a daunting task.

So here's what we are going to do.
We are going to use a new branch titled "typescript." So that all of the work can be done in typescript, then we will merge the change into our master branch periodically.

Important

Please follow the steps below when doing Typescript conversion.

  • You should open a new issue titled with the structure of "Upgrading xx.js(x) to xx.ts(x)", where xx.js is the file you are converting to typescript.
  • Then, you want to self-assign yourself to the issue so that others know.
  • After the conversion, you may want to specify the path of the your file you have made changes on, as well as any other noteworthy code you have written.
  • Finally refer to this root issue (using #) and choose the "Typescripting our project" milestone in your issue.
@hanseaston hanseaston added enhancement enhancement on an existing feature javascript labels Aug 9, 2020
@hanseaston hanseaston added this to the Typescripting our project milestone Aug 9, 2020
@hanseaston hanseaston changed the title Converting project to using Typescript Milestone: Converting project to using Typescript Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement on an existing feature javascript
Projects
None yet
Development

No branches or pull requests

1 participant