Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone: Transforming our project's CSS #31

Open
hanseaston opened this issue Aug 9, 2020 · 1 comment
Open

Milestone: Transforming our project's CSS #31

hanseaston opened this issue Aug 9, 2020 · 1 comment
Labels
css frontend ideas wanted Need ideas and inputs from others

Comments

@hanseaston
Copy link
Owner

Right now, our CSS style is global, which isn't ideal if our project scales up.

We have two (definitely more, feel free to brainstorm) options, either using CSS modules, or styled Components.
I personally would prefer using CSS modules because it's easier to get your feet wet and get started, but I definitely see some tradeoffs.

Since this is a big task (transforming all of our project's style is a lot of work), we will tackle the style one file after another using individual tracking issues. We will probably imitate the protocol resembling #25 to make progress slowly.

I'm listing this as one of the major milestones.

Please let me know what you think.

@hanseaston hanseaston added ideas wanted Need ideas and inputs from others frontend css labels Aug 9, 2020
@hanseaston hanseaston added this to the Transforming CSS milestone Aug 9, 2020
@li3097
Copy link

li3097 commented Oct 19, 2020

I was originally looking at the about page since that was the issue listed on http://issuehub.io/?label%5B%5D=html&label%5B%5D=enhancement&language=

If I am understanding this issue, its the bigger version of the one listed on issuehub.io. I am thinking doing something similar to this https://images.template.net/wp-content/uploads/2017/04/17122905/Online-Food-Delivery-Website-Template.jpg with the brown from your potato logo instead of the black listed. The picture was just a loose idea of what I am thinking. I could add a css page to get started but I am not quite familiar enough with the languages used to connect the pages.
For a quick 'fix' to the about page, I was thinking adding a wide header picture with some text on it to make it look less thrown together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css frontend ideas wanted Need ideas and inputs from others
Projects
None yet
Development

No branches or pull requests

2 participants